search

MilkBowl / Vault

Vault of common APIs for Bukkit Plugins
GNU Lesser General Public License v3.0
496 stars 354 forks source link

Finish removal of native support for abandoned economy plugins. #863

Closed LlmDl closed 2 years ago

LlmDl commented 3 years ago

This Pull Request complements https://github.com/MilkBowl/VaultAPI/pull/112 in finishing the removal of economy plugins from Vault. This process was begun years ago when many other such economy plugins were removed after being determined abandoned.

The modern standard is that an economy plugin will implement Vault in their own code.

Here are the last-update dates on the plugins removed: Capture

LlmDl commented 3 years ago

Took me a few tries to get this building properly, locally it complains about the pom formatting but it is building now as best it can. CI only failed to deploy after building correctly.

mirolm commented 3 years ago

Agree on that - EssentialsX currently has code to load Vault properly. It will be good to let go of the old economy code.

P.S. Maybe the same can be done with the old permission plugins code too...

LlmDl commented 3 years ago

@mirolm thanks for taking a look, this PR goes hand in hand with one I have open at the VaultAPI repo.

Might be possible to do something similar to permission and chat plugins but I'm more concerned with Economy's future.

cerealcable commented 2 years ago

This PR has failed checks (we've sinced fixed the build configs, so rebase) and has conflicts. Any chance @LlmDl you could address this and then we'll be able to get to final reviews/merging?

Jack1424 commented 2 years ago

You should remove these plugins from the README as well

LlmDl commented 2 years ago

I will do that as well.

LlmDl commented 2 years ago

First PR to build in a decade! /s

LlmDl commented 2 years ago

Just back from holiday and I see this is merged, very nice! I'll start work on your Vault-API review tomorrow.