search

MilkBowl / Vault

Vault of common APIs for Bukkit Plugins
GNU Lesser General Public License v3.0
495 stars 350 forks source link

[Vault]: Loading Vault v1.7.3-b${env.TRAVIS_BUILD_NUMBER} #899

Closed AxlRose-RX closed 2 years ago

AxlRose-RX commented 2 years ago

Not really an issue, but is it supposed to show up like that on console?

[Vault]: Loading Vault v1.7.3-b${env.TRAVIS_BUILD_NUMBER}

image

Am I supposed to drop the 2 resulting .jars into the plugin folder or just the Vault-1.7.3.jar?

image

cerealcable commented 2 years ago

Was this build manually? Looks like an environment variable wasn't provided during build time thus resulting in the TRAVIS_BUILD_NUMBER string.

AxlRose-RX commented 2 years ago

I just used mvn to build it after cloning, was I supposed to provide some some extra arguments to mvn?

cerealcable commented 2 years ago

Yes, building outside of the build pipeline (travis) would mean you should expect some quirks. Shouldn't be too hard to provide a default variable of "snapshot" or something in it's place instead for local builds. Since this doesn't impact releases it's unlike we'll fix it but someone could open a PR if they wish.

AxlRose-RX commented 2 years ago

also what do I get on my server from using this up to date build instead of the Spigot one that has not been updated in 2 years?

Jack1424 commented 2 years ago

You can see all of the changes made in the commit history.