MilkBowl / Vault

Vault of common APIs for Bukkit Plugins
GNU Lesser General Public License v3.0
495 stars 350 forks source link

Please update to 1.19.x #912

Open AlexGuignard opened 1 year ago

AlexGuignard commented 1 year ago

I'm trying to make a server but plugins require yours and it simply does not work / recognize it

Jack1424 commented 1 year ago

Vault should work on 1.19. Please send a list of the plugins that you're using and the server logs.

AlexGuignard commented 1 year ago

hi the main plugin that requires vault and does not work is AuctionHouse there is a second one pyrophishing that says it doesnt work but still does

AlexGuignard commented 1 year ago

https://www.spigotmc.org/resources/auctionhouse.61836/

https://www.spigotmc.org/resources/pyrofishingpro-1-14-x-1-19-x-1-fishing-plugin-new-tournament-rework.60729/

AlexGuignard commented 1 year ago

having this error : [22:54:48 ERROR]: [AuctionHouse] Error! No plugin supporting Vault's Economy API was found! [22:54:48 ERROR]: [AuctionHouse] Plugin will be disabled!

and this one

[22:54:39 WARN]: [PyroFishingPro] - Vault not found. Will use CommandSelling regardless of setting in config.yml Please install Vault if you wish to use another setting.

AlexGuignard commented 1 year ago

I have vault 1.7.3 installed and it is supposed to require 1.5 and higher ( tried 1.5 didnt work either )

AlexGuignard commented 1 year ago

gonna try to just replace auciotnhouse with playerauciton

AlexGuignard commented 1 year ago

all plugins supposed to require vault throw an error or warning and either stil work or dont but it seems to be random kinda

AlexGuignard commented 1 year ago

PlayerAuction worked so i guess it is up to aucitonHouse dev to fix it sorry but it still seems that the handled version that you plugin says it does still are weirdly done ( still at 1.16 on spigot website )

cerealcable commented 1 year ago

Did you see Vault logs in your startup? Are you confident Vault is present in your configuration here? I've had Vault running on 1.19.x for quite a while. Also, Vault has no requirements to update for new versions of Minecraft, Spigot, Paper, etc because Vault itself has very little to support outside of just connecting plugins together via a common interface. Past that, it's really up to the plugins and Vault is just an intermediary here.

Many issues like this one have come and gone, we don't update Spigot or other sites because we don't really have new releases these days so why update Spigot's "1.16" version when the old version still works?

Geolykt commented 1 year ago

If you use Paper you might want to be aware that plugins depending on vault may have improper plugin.ymls and will thus refuse to load - thus causing a chain reaction.

Logs are the only proper way to find the source of your problem.

imDaniX commented 1 year ago

having this error : [22:54:48 ERROR]: [AuctionHouse] Error! No plugin supporting Vault's Economy API was found! [22:54:48 ERROR]: [AuctionHouse] Plugin will be disabled!

I'd suggest that you don't have a plugin that provides Vault's economy implementation, such as EssentialsX. Vault by itself doesn't provide economy - only a common API for that.

AlexGuignard commented 1 year ago

If you use Paper you might want to be aware that plugins depending on vault may have improper plugin.ymls and will thus refuse to load - thus causing a chain reaction.

Logs are the only proper way to find the source of your problem.

I am in fact running on paper and dont rly know how to fix it but i have made my way around the issue

AlexGuignard commented 1 year ago

having this error : [22:54:48 ERROR]: [AuctionHouse] Error! No plugin supporting Vault's Economy API was found! [22:54:48 ERROR]: [AuctionHouse] Plugin will be disabled!

I'd suggest that you don't have a plugin that provides Vault's economy implementation, such as EssentialsX. Vault by itself doesn't provide economy - only a common API for that.

I Did

winnipeg21 commented 1 year ago

To use your plugins you must have them up-to-date, install vault than install an ECO plugin such as EssentialsX and make sure the economy portion is enabled/functioning. It is working for me on 1.19 with those same plugins.

If you are using Web FTP / Uploading plugins via a web panel, i suggest reuploading or using a prob FTP client such as WinSCP

amadeusmz commented 1 year ago
    private boolean setupEconomy() {
        if (this.getServer().getPluginManager().getPlugin("Vault") == null) {
            main.getLogger().warning("Vault not found");
            return false;
        }
        RegisteredServiceProvider<Economy> rsp = this.getServer()
            .getServicesManager()
            .getRegistration(Economy.class);
        if (rsp == null) {
            main.getLogger().warning("rsp == null");
            return false;
        }
        econ = rsp.getProvider();
        return true;
    }

rsp becomes null when I update to 1.19.4

MatinHQ commented 1 year ago

Can Confirm vault is broken on 1.19.4

And Even plugins like AuctionHouse, EzChestShop, NFCNotes, MYsqlEconomyBank, CMI, and many others can't hook into it

Plugin starts up correctly without an error but other plugins are unable to hook into it

Geolykt commented 1 year ago

Can Confirm vault is broken on 1.19.4

And Even plugins like AuctionHouse, EzChestShop, NFCNotes, MYsqlEconomyBank, CMI, and many others can't hook into it

Plugin starts up correctly without an error but other plugins are unable to hook into it

Can you send the log files?

TheWylot commented 1 year ago

Can Confirm vault is broken on 1.19.4

And Even plugins like AuctionHouse, EzChestShop, NFCNotes, MYsqlEconomyBank, CMI, and many others can't hook into it

Plugin starts up correctly without an error but other plugins are unable to hook into it

try using EssentialsX, as Vault is a library, it's fix for me with EssentialsX

Geolykt commented 1 year ago

If that fixes it it is because you forgot to register an economy. You need to use an economy plugin in order for vault to provide an economy.

But that is speculation as usual