Add Support Folia without Bukkit Scheduler or GlobalScheduler

MilkBowl / Vault

Vault of common APIs for Bukkit Plugins

GNU Lesser General Public License v3.0

495 stars 350 forks source link

Add Support Folia without Bukkit Scheduler or GlobalScheduler #916

Open Euphillya opened 1 year ago

Euphillya commented 1 year ago

I added Folia support without breaking previous versions for Spigot. I removed the Bukkit Scheduler implementation to use the Concurrent Executors implementation which is much more maintainable than using an implementation that requires to use another package for Folia like here https://github.com/MilkBowl/Vault/pull/915

GeorgeV220 commented 1 year ago

I believe Vault is abandoned, so probably a new fork with a different name like Vault2 or X should be made, idk to be honest.

Clercq commented 1 year ago

AFAIK the native java threading can cause some issues during the server disabling, if thread is not stopped:/

It's better to have the library that will have java 8 support, and will have support 4 all server-cores API(spigot, paper, folia) smth like this: https://github.com/Anon8281/UniversalScheduler

Q2297045667 commented 3 months ago

Can he be merged?

Euphillya commented 3 months ago

Can he be merged?

The plugin is abandoned