Milkdown / milkdown

đŸŧ Plugin driven WYSIWYG markdown editor framework.
https://milkdown.dev
MIT License
8.64k stars 386 forks source link

fix: slash menu scroll behavior #1386

Closed Saul-Mirone closed 2 months ago

Saul-Mirone commented 2 months ago

Summary

Fix the double scroll behavior of slash menu

How did you test this change?

CI and manually

vercel[bot] commented 2 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗ī¸Ž

Name Status Preview Comments Updated (UTC)
milkdown-storybook ✅ Ready (Inspect) Visit Preview đŸ’Ŧ Add feedback Jun 19, 2024 2:13am
nx-cloud[bot] commented 2 months ago

☁ī¸ Nx Cloud Report

CI is running/has finished running commands for commit cd04f4dc7ef7f6eb4123d0e2f9d3ee7c69637df1. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 3 targets - [`nx build @milkdown/e2e`](https://cloud.nx.app/runs/YM1DYSmlOJ?utm_source=pull-request&utm_medium=comment) - [`nx run-many --target=tsc --all --parallel`](https://cloud.nx.app/runs/0ML3WNWXLb?utm_source=pull-request&utm_medium=comment) - [`nx run-many --target=build --all --parallel`](https://cloud.nx.app/runs/7t7W4N8sgB?utm_source=pull-request&utm_medium=comment)

Sent with 💌 from NxCloud.

cypress[bot] commented 2 months ago

Passing run #905 ↗ī¸Ž

0 83 0 0 Flakiness 0

Details:

Merge cd04f4dc7ef7f6eb4123d0e2f9d3ee7c69637df1 into 097532e85d60991330cd161311e3...
Project: Default Project Commit: 71bc67b819 ℹī¸
Status: Passed Duration: 01:45 💡
Started: Jun 19, 2024 2:16 AM Ended: Jun 19, 2024 2:18 AM

Review all test suite changes for PR #1386 ↗ī¸Ž

cypress[bot] commented 2 months ago

Passing run #906 ↗ī¸Ž

0 83 0 0 Flakiness 0

Details:

fix: slash menu scroll behavior (#1386)
Project: Default Project Commit: cc6a3eba3a
Status: Passed Duration: 01:33 💡
Started: Jun 19, 2024 2:23 AM Ended: Jun 19, 2024 2:25 AM

Review all test suite changes for PR #1386 ↗ī¸Ž