Closed ocavue closed 1 month ago
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
milkdown-storybook | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Jul 3, 2024 4:28pm |
Thanks for your contribution!
CI is running/has finished running commands for commit ff63ca8fc04c2012ba1dc9cee60bc0a716a592dc. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.
📂 See all runs for this CI Pipeline Execution
Sent with 💌 from NxCloud.
![]() |
![]() |
![]() |
![]() |
![]() |
Details:
refactor: replace autoInsertZeroSpaceInTablePlugin with prosemirror-safari-ime-s... | |||
Project: Default Project | Commit: 23b4ac6246 |
||
Status: Passed | Duration: 01:32 💡 | ||
Started: Jul 3, 2024 4:45 PM | Ended: Jul 3, 2024 4:46 PM |
Summary
This PR replaces
autoInsertZeroSpaceInTablePlugin()
with a standalone packageprosemirror-safari-ime-span
. I believeprosemirror-safari-ime-span
has two benefits compared toautoInsertZeroSpaceInTablePlugin()
:state.doc
. This ensure that the document won't contain unexpected zero width character if thecompositionend
event is not called.How did you test this change?
I used IME to type some words in a Storybook table within Safari.