Milkdown / milkdown

đŸŧ Plugin driven WYSIWYG markdown editor framework.
https://milkdown.dev
MIT License
8.64k stars 386 forks source link

fix: 🐛 table issues #1405

Closed Saul-Mirone closed 1 month ago

Saul-Mirone commented 1 month ago

Summary

  1. Drag handle shouldn't display on table cell.
  2. Split table should keep cell alignment.
  3. Remove remove-possible-table plugin because it can be replaced by setting allowTableNodeSelection: true to table editing plugin.

How did you test this change?

Manually and CI

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗ī¸Ž

Name Status Preview Comments Updated (UTC)
milkdown-storybook ✅ Ready (Inspect) Visit Preview đŸ’Ŧ Add feedback Jul 6, 2024 2:02pm
nx-cloud[bot] commented 1 month ago

☁ī¸ Nx Cloud Report

CI is running/has finished running commands for commit e25ccbc7d0dc579c1194c2d6deb3479cf0d955b0. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 3 targets - [`nx build @milkdown/e2e`](https://cloud.nx.app/runs/96Ei9Q6lFu?utm_source=pull-request&utm_medium=comment) - [`nx run-many --target=tsc --all --parallel`](https://cloud.nx.app/runs/oZpOTeCNPc?utm_source=pull-request&utm_medium=comment) - [`nx run-many --target=build --all --parallel`](https://cloud.nx.app/runs/VHcDk0xJe2?utm_source=pull-request&utm_medium=comment)

Sent with 💌 from NxCloud.

cypress[bot] commented 1 month ago

Passing run #937 ↗ī¸Ž

0 83 0 0 Flakiness 0

Details:

Merge e25ccbc7d0dc579c1194c2d6deb3479cf0d955b0 into 758726a71ffc1b1e1bcd3066b73b...
Project: Default Project Commit: e19d272196 ℹī¸
Status: Passed Duration: 02:03 💡
Started: Jul 6, 2024 2:07 PM Ended: Jul 6, 2024 2:09 PM

Review all test suite changes for PR #1405 ↗ī¸Ž

cypress[bot] commented 1 month ago

Passing run #938 ↗ī¸Ž

0 83 0 0 Flakiness 0

Details:

fix: 🐛 table issues (#1405)
Project: Default Project Commit: d596b171b7
Status: Passed Duration: 01:39 💡
Started: Jul 6, 2024 3:55 PM Ended: Jul 6, 2024 3:57 PM

Review all test suite changes for PR #1405 ↗ī¸Ž