Milkdown / milkdown

đŸŧ Plugin driven WYSIWYG markdown editor framework.
https://milkdown.dev
MIT License
8.64k stars 386 forks source link

fix: table dnd cannot work sometimes #1411

Closed Saul-Mirone closed 1 month ago

Saul-Mirone commented 1 month ago

Summary

Table drag and drop cannot work sometimes because of a chrome bug: https://stackoverflow.com/questions/14203734/dragend-dragenter-and-dragleave-firing-off-immediately-when-i-drag

How did you test this change?

CI and manually

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗ī¸Ž

Name Status Preview Comments Updated (UTC)
milkdown-storybook ✅ Ready (Inspect) Visit Preview đŸ’Ŧ Add feedback Jul 10, 2024 2:55am
nx-cloud[bot] commented 1 month ago

☁ī¸ Nx Cloud Report

CI is running/has finished running commands for commit 7472f3aa10485efc69546c478d213a894388a057. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 3 targets - [`nx build @milkdown/e2e`](https://cloud.nx.app/runs/wxwyjbsVXE?utm_source=pull-request&utm_medium=comment) - [`nx run-many --target=tsc --all --parallel`](https://cloud.nx.app/runs/lyWMtWhl2g?utm_source=pull-request&utm_medium=comment) - [`nx run-many --target=build --all --parallel`](https://cloud.nx.app/runs/cgq2JYvSKy?utm_source=pull-request&utm_medium=comment)

Sent with 💌 from NxCloud.

cypress[bot] commented 1 month ago

Passing run #951 ↗ī¸Ž

0 83 0 0 Flakiness 0

Details:

Merge 7472f3aa10485efc69546c478d213a894388a057 into 77d0c44162a5e1f0c667b5be3f46...
Project: Default Project Commit: 3a29d9e82c ℹī¸
Status: Passed Duration: 01:51 💡
Started: Jul 10, 2024 2:58 AM Ended: Jul 10, 2024 3:00 AM

Review all test suite changes for PR #1411 ↗ī¸Ž

cypress[bot] commented 1 month ago

Passing run #952 ↗ī¸Ž

0 83 0 0 Flakiness 0

Details:

fix: table dnd cannot work sometimes (#1411)
Project: Default Project Commit: 0319b836f3
Status: Passed Duration: 01:35 💡
Started: Jul 10, 2024 3:04 AM Ended: Jul 10, 2024 3:06 AM

Review all test suite changes for PR #1411 ↗ī¸Ž