search

Milkshiift / GoofCord

:shield: Take control of your Discord experience with GoofCord – a highly configurable and privacy minded discord client.
Open Software License 3.0
203 stars 7 forks source link

[BUG] Screen Share resolution selection not working #13

Closed CogumeloDoZap closed 5 months ago

CogumeloDoZap commented 5 months ago

Description

Goofcord can't share screen with 1080p or 480p

Steps to Reproduce

Try share screen with less than 720p(or more)

Expected Behavior

Share screen with chosen resolution

Actual Behavior

Screen share is limited to 720p 30fps

Screenshots

image-23.png

image-18.png

Environment

Milkshiift commented 5 months ago

Do you use Vencord as a client mod? Do you have "Script loading" enabled? And can you open DevTools and screenshot contents of the console tab after starting screenshare?

CogumeloDoZap commented 5 months ago

script loading is enabled. I'm using vencord as client mod. image-16.png

Milkshiift commented 5 months ago

Please scroll down and screenshot last messages in the console

CogumeloDoZap commented 5 months ago

image-26.png

Milkshiift commented 5 months ago

The script that manages screenshare quality doesn't load. That happens because of a pretty broken detection system for when Discord is loaded. This is already fixed upstream and will be part of the next release. I will see if I can make a temporary fix