search

Milkshiift / GoofCord

:shield: Take control of your Discord experience with GoofCord – a highly configurable and privacy minded discord client.
Open Software License 3.0
203 stars 7 forks source link

Fix VAAPI flags, and fix icons on Windows and Linux. #15

Closed Alex313031 closed 4 months ago

Alex313031 commented 4 months ago

VAAPI is only applicable on Linux, so move all VAAPI flags there.

The autoplay flag should come before the enable/disable features flags, as those should come last on the commandline.

The Windows .ico only had one size, 256px. A Windows icon is supposed to have 16, 32, 48, 64, and 256px. This was causing the image to look rough around the edges in the tray and welcome dialog, since it was having to resize the 256 ico all the way down to 16px.

In addition, Linux was using the .icns for Electron builder. This won't even show up correctly, that's only for MacOS. Instead, use a dir with all the sizes normally used for an app in /usr/share/icons/hicolor/

Lastly, an .ico should be used on Windows for getCustomIcon, a .png for MacOS and Linux, when using electron's nativeImage.

Milkshiift commented 4 months ago

Electron-builder automatically generates needed icons from the .icns file for a Linux build https://www.electron.build/configuration/linux. I don't think there is a reason to make the icons manually

Alex313031 commented 4 months ago

@Milkshiift Ahh, you're right. My OCD still makes me want to make the icons manually lol, but to each his own.