Milkshiift / GoofCord

:shield: Take control of your Discord experience with GoofCord – a highly configurable and privacy minded discord client.
Open Software License 3.0
203 stars 7 forks source link

Build GoodCord on macOS #4

Closed jacksongoode closed 11 months ago

jacksongoode commented 1 year ago

https://github.com/Milkshiift/GoofCord/blob/918c75d9ec4df1acd56ea84f1447dc31a55f8d02/src/content/css/titlebar.css#L239

Since it's been supported in the recent release of ArmCord (see https://github.com/ArmCord/ArmCord/commit/bcb54b4f793d14acd195a3efed0e82fc940b770d) I would think it might be easy to build Goof as well?

I hope so!

Milkshiift commented 1 year ago

It's not that straightforward sadly. I don't have a macOS device so I can't test the app at all. If I had someone who can test it, it would be much easier. In the upcoming update, I will try to implement an alpha-level macOS support.

Added to the Roadmap

I'll be keeping this issue open to provide updates on the progress of macOS support.

jacksongoode commented 1 year ago

Would really be excited to see this given that ArmCord development has slowed.

Milkshiift commented 11 months ago

Added macOS support, I hope it at least launches 😬

jacksongoode commented 11 months ago

Trying it now!

jacksongoode commented 11 months ago

Or I'll try it once a build is release!

Milkshiift commented 11 months ago

I can publish a pre-release with macos build

Milkshiift commented 11 months ago

https://github.com/Milkshiift/GoofCord/releases/tag/v1.0.0 Here

Milkshiift commented 11 months ago

it's a pre-release so things will be buggy

jacksongoode commented 11 months ago

Hmm, appears to be running under Intel on my arm Macbook. Maybe it built incorrectly.

Milkshiift commented 11 months ago

I think I know what's the issue. I will notify you when I rebuild with a fix

jacksongoode commented 11 months ago

Thanks!

Milkshiift commented 11 months ago

Made a new release with macOS support. You need to download the arm64 dmg file. Hope it works for you. Also, can you, if possible, screenshot the titlebar and attach it here? I'm not sure it shows up as expected. Thanks.

jacksongoode commented 11 months ago
image

It runs on my end! The title bar is quite wonky tho 🤭

Milkshiift commented 11 months ago

Fixed it. Should be normal in the next update. Also, this issue is super closed now, open another issue if you encounter any problems