Cannot build nbody_graphic anymore

[LocutusOfBorg]

After commit 1ba9a6da61bc578e7a3d004a53c30c026e118f4d I cannot build graphic anymore

make[3]: uscita dalla directory "/home/locutus/branches/boinc_stuff/milkywayathome_client/obj-x86_64-linux-gnu" make -f nbody/CMakeFiles/milkyway_nbody_graphics.dir/build.make nbody/CMakeFiles/milkyway_nbody_graphics.dir/build make[3]: ingresso nella directory "/home/locutus/branches/boinc_stuff/milkywayathome_client/obj-x86_64-linux-gnu" /usr/bin/cmake -E cmake_progress_report /home/locutus/branches/boinc_stuff/milkywayathome_client/obj-x86_64-linux-gnu/CMakeFiles 49 [ 96%] Building CXX object nbody/CMakeFiles/milkyway_nbody_graphics.dir/src/nbody_gl.cpp.o cd /home/locutus/branches/boinc_stuff/milkywayathome_client/obj-x86_64-linux-gnu/nbody && /usr/bin/c++ -DDOUBLEPREC=1 -DDSFMT_MEXP=19937 -static-libgcc -pthread -fno-unsafe-math-optimizations -fno-common -funswitch-loops -maccumulate-outgoing-args -Wall -Wextra -Wshadow -Wredundant-decls -Winline -Wdisabled-optimization -Wpointer-arith -Wcast-align -Wstrict-aliasing -Wstrict-aliasing=3 -Wswitch-enum -Wswitch-default -Wfloat-equal -Wwrite-strings -Wcomment -Wno-unknown-pragmas -fno-rounding-math -fno-math-errno -fopenmp -O2 -g -I/home/locutus/branches/boinc_stuff/milkywayathome_client/obj-x86_64-linux-gnu/include -I/home/locutus/branches/boinc_stuff/milkywayathome_client/third_party/include -I/home/locutus/branches/boinc_stuff/milkywayathome_client/glm -I/home/locutus/branches/boinc_stuff/milkywayathome_client/popt/include -I/home/locutus/branches/boinc_stuff/milkywayathome_client/lua/include -I/home/locutus/branches/boinc_stuff/milkywayathome_client/glfw/include -I/home/locutus/branches/boinc_stuff/milkywayathome_client/milkyway/include -I/home/locutus/branches/boinc_stuff/milkywayathome_client/dSFMT -I/home/locutus/branches/boinc_stuff/milkywayathome_client/nbody/include -I/home/locutus/branches/boinc_stuff/milkywayathome_client/crlibm -I/home/locutus/branches/boinc_stuff/milkywayathome_client/openpa/include -ffast-math -o CMakeFiles/milkyway_nbody_graphics.dir/src/nbody_gl.cpp.o -c /home/locutus/branches/boinc_stuff/milkywayathome_client/nbody/src/nbody_gl.cpp /home/locutus/branches/boinc_stuff/milkywayathome_client/nbody/src/nbody_gl.cpp: In function ‘void resizeHandler(void, int, int)’: /home/locutus/branches/boinc_stuff/milkywayathome_client/nbody/src/nbody_gl.cpp:460:27: error: too many arguments to function ‘void glfwSwapBuffers()’ In file included from /home/locutus/branches/boinc_stuff/milkywayathome_client/nbody/include/nbody_gl_includes.h:32:0, from /home/locutus/branches/boinc_stuff/milkywayathome_client/nbody/src/nbody_gl.cpp:22: /home/locutus/branches/boinc_stuff/milkywayathome_client/glfw/include/GL/glfw3.h:582:15: note: declared here /home/locutus/branches/boinc_stuff/milkywayathome_client/nbody/src/nbody_gl.cpp: In function ‘void mouseButtonHandler(void, int, int)’: /home/locutus/branches/boinc_stuff/milkywayathome_client/nbody/src/nbody_gl.cpp:517:36: error: ‘glfwGetCursorPos’ was not declared in this scope /home/locutus/branches/boinc_stuff/milkywayathome_client/nbody/src/nbodygl.cpp: In function ‘void nbglSetHandlers(void**)’: ()(void_)}’ for argument ‘1’ to ‘void glfwSetWindowCloseCallback(GLFWwindowclosefun)’ /home/locutus/branches/boinc_stuff/milkywayathome_client/nbody/src/nbodygl.cpp:765:42: error: cannot convert ‘void**’ to ‘GLFWkeyfun {aka void ()(void_, int, int)}’ for argument ‘1’ to ‘void glfwSetKeyCallback(GLFWkeyfun)’ /home/locutus/branches/boinc_stuff/milkywayathome_client/nbody/src/nbodygl.cpp:766:44: error: cannot convert ‘void**’ to ‘GLFWcharfun {aka void ()(void_, int)}’ for argument ‘1’ to ‘void glfwSetCharCallback(GLFWcharfun)’ /home/locutus/branches/boinc_stuff/milkywayathome_client/nbody/src/nbodygl.cpp:767:58: error: cannot convert ‘void**’ to ‘GLFWmousebuttonfun {aka void ()(void_, int, int)}’ for argument ‘1’ to ‘void glfwSetMouseButtonCallback(GLFWmousebuttonfun)’ /home/locutus/branches/boinc_stuff/milkywayathome_client/nbody/src/nbody_gl.cpp:768:53: error: ‘glfwSetCursorPosCallback’ was not declared in this scope /home/locutus/branches/boinc_stuff/milkywayathome_client/nbody/src/nbodygl.cpp:769:48: error: cannot convert ‘void**’ to ‘GLFWscrollfun {aka void ()(void_, int, int)}’ for argument ‘1’ to ‘void glfwSetScrollCallback(GLFWscrollfun)’ /home/locutus/branches/boinc_stuff/milkywayathome_client/nbody/src/nbody_gl.cpp: In function ‘void nbglRandomParticleColor(Color&)’: /home/locutus/branches/boinc_stuff/milkywayathome_client/nbody/src/nbody_gl.cpp:1131:25: warning: comparing floating point with == or != is unsafe [-Wfloat-equal] /home/locutus/branches/boinc_stuff/milkywayathome_client/nbody/src/nbody_gl.cpp: In member function ‘void NBodyGraphics::loadColors()’: /home/locutus/branches/boinc_stuff/milkywayathome_client/nbody/src/nbody_gl.cpp:1158:32: warning: comparing floating point with == or != is unsafe [-Wfloat-equal] /home/locutus/branches/boinc_stuff/milkywayathome_client/nbody/src/nbody_gl.cpp: In member function ‘void NBodyGraphics::mainLoop()’: /home/locutus/branches/boinc_stuff/milkywayathome_client/nbody/src/nbody_gl.cpp:1345:37: error: too many arguments to function ‘void glfwSwapBuffers()’ In file included from /home/locutus/branches/boinc_stuff/milkywayathome_client/nbody/include/nbody_gl_includes.h:32:0, from /home/locutus/branches/boinc_stuff/milkywayathome_client/nbody/src/nbody_gl.cpp:22: /home/locutus/branches/boinc_stuff/milkywayathome_client/glfw/include/GL/glfw3.h:582:15: note: declared here /home/locutus/branches/boinc_stuff/milkywayathome_client/nbody/src/nbody_gl.cpp: In member function ‘void NBodyGraphics::findInitialOrientation()’: /home/locutus/branches/boinc_stuff/milkywayathome_client/nbody/src/nbody_gl.cpp:1424:41: warning: comparing floating point with == or != is unsafe [-Wfloat-equal] /home/locutus/branches/boinc_stuff/milkywayathome_client/nbody/src/nbody_gl.cpp:1437:18: warning: comparing floating point with == or != is unsafe [-Wfloat-equal] /home/locutus/branches/boinc_stuff/milkywayathome_client/nbody/src/nbody_gl.cpp:1437:31: warning: comparing floating point with == or != is unsafe [-Wfloat-equal] /home/locutus/branches/boinc_stuff/milkywayathome_client/nbody/src/nbody_gl.cpp: In function ‘void nbglRequestGLVersion()’: /home/locutus/branches/boinc_stuff/milkywayathome_client/nbody/src/nbody_gl.cpp:1472:20: error: ‘GLFW_CONTEXT_VERSION_MAJOR’ was not declared in this scope /home/locutus/branches/boinc_stuff/milkywayathome_client/nbody/src/nbody_gl.cpp:1472:49: error: ‘glfwWindowHint’ was not declared in this scope /home/locutus/branches/boinc_stuff/milkywayathome_client/nbody/src/nbody_gl.cpp:1473:20: error: ‘GLFW_CONTEXT_VERSION_MINOR’ was not declared in this scope /home/locutus/branches/boinc_stuff/milkywayathome_client/nbody/src/nbody_gl.cpp:1478:20: error: ‘GLFW_SAMPLES’ was not declared in this scope /home/locutus/branches/boinc_stuff/milkywayathome_client/nbody/src/nbody_gl.cpp: In function ‘void* nbglPrepareWindow(const VisArgs)’: /home/locutus/branches/boinc_stuff/milkywayathome_client/nbody/src/nbody_gl.cpp:1488:5: error: ‘GLFWmonitor’ was not declared in this scope /home/locutus/branches/boinc_stuff/milkywayathome_client/nbody/src/nbody_gl.cpp:1488:18: error: ‘monitor’ was not declared in this scope /home/locutus/branches/boinc_stuff/milkywayathome_client/nbody/src/nbody_gl.cpp:1488:50: error: ‘glfwGetPrimaryMonitor’ was not declared in this scope /home/locutus/branches/boinc_stuff/milkywayathome_client/nbody/src/nbody_gl.cpp:1495:23: error: ‘monitors’ was not declared in this scope /home/locutus/branches/boinc_stuff/milkywayathome_client/nbody/src/nbody_gl.cpp:1495:59: error: ‘glfwGetMonitors’ was not declared in this scope /home/locutus/branches/boinc_stuff/milkywayathome_client/nbody/src/nbody_gl.cpp:1504:51: error: ‘glfwGetVideoMode’ was not declared in this scope /home/locutus/branches/boinc_stuff/milkywayathome_client/nbody/src/nbody_gl.cpp:1512:68: error: ‘glfwCreateWindow’ was not declared in this scope /home/locutus/branches/boinc_stuff/milkywayathome_client/nbody/src/nbody_gl.cpp:1519:68: error: ‘glfwCreateWindow’ was not declared in this scope /home/locutus/branches/boinc_stuff/milkywayathome_client/nbody/src/nbody_gl.cpp:1521:1: warning: control reaches end of non-void function [-Wreturn-type]

[LocutusOfBorg]

Could anybody please fix or revert it?

[arsenm]

Fixed with 771fd482e837a38b33450b483d78cf84be0f1dd8 and 36a96c1e1f4f4f6b22b81216deff1b3b8d8a4dcc

You'll need to run git submodule update to get the latest glfw3. I'm guessing it stopped working for you before last time I updated the submodule.

[LocutusOfBorg]

Yeah, thanks, I was aware of the submodule update no problem :)

Many thanks, now it's building well!

Just one side question, I'm currently building nbody, separation and nbody_graphics, do you know some more packages I can build?

and nbody_separation_graphics fails to build from source /home/locutus/branches/boinc_stuff/milkywayathome_client/separation/src/separation_graphics.cc: In function ‘void separationGraphicsCallback()’: /home/locutus/branches/boinc_stuff/milkywayathome_client/separation/src/separation_graphics.cc:47:15: error: ‘struct EvaluationState’ has no member named ‘integrals’ make[2]: * [separation/CMakeFiles/separation.dir/src/separation_graphics.cc.o] Errore 1 make[1]: * [separation/CMakeFiles/separation.dir/all] Errore 2

[LocutusOfBorg]

of course adding variable integrals to separation/include/separation_types.h fixes the problem, but is this what you intend to do? Or maybe drop the variable in graphics.cc?

[arsenm]

The separation graphics isn't real. I don't expect it to work.