search

MilleXIV / XIV_Databar

19 stars 19 forks source link

Smelding is not a spell anymore #11

Closed Mikeprod closed 8 years ago

Mikeprod commented 8 years ago

I reopened this pull request, having however figured out that the toggle blocks any action from the spellbook, but not the skill itself for crafting professions.

Mikeprod commented 8 years ago

Closing temporarily this pull request until implementation following the Issue #14

Mikeprod commented 8 years ago

Added the clock fix #13 in the last commit, but more important the trade skill fix in the first commit answering #14

MilleXIV commented 8 years ago

Closing this as the rewrite invalidates. Switched to SecureActionButtonTemplate and using SpellBookItemName() to fetch the proper spell. Thanks anyway.

Mikeprod commented 8 years ago

Sry for reopening this but It does not work on non english clients ... with GetSpellBookItemName() That is why I used select(6,GetProfessionInfo(profession)) to get the proper name of the profession ;)

MilleXIV commented 8 years ago

Which language are you using? I've just tested in English and Spanish (EU) and it worked in both cases.

Mikeprod commented 8 years ago

My bad did not pull the right version :S