search

MilleXIV / XIV_Databar

19 stars 19 forks source link

Rework Travel module port option #31

Open MilleXIV opened 8 years ago

MilleXIV commented 8 years ago

Currently it does not refresh nearly enough, and misses out on options. Also setting to garrison hearthstone as default is a problem at this point.

MilleXIV commented 8 years ago

I've made the list refresh on enable and on the SPELLS_CHANGED, BAG_UPDATE_DELAYED, and HEARTHSTONE_BOUND events.

It now defaults to the first entry in the portOptions or Dalaran Hearthstone otherwise, which is probably a better default than the Garrison Hearthstone at this point.

Still need to test this on a character that acquires their class hall access later. Make sure it adds it to the list without a /reload. Thankfully I do have a level 100 Mage I can test it with tonight.

NerfOnline commented 8 years ago

Since we're talking about the Travel module, right clicking isn't allowing me to change the port like it says on the tooltip.

MilleXIV commented 8 years ago

Does it not bring up anything, or does it show the popup with nothing in it?

NerfOnline commented 8 years ago

When I click it tries to use the Dalaran hearth as it's the default. When I right click, nothing happens at all. When I hover over it, it does show the tooltip though, but that's it.

Vegeir commented 8 years ago

I didn't notice this issue but I am having the same problem on my mage. I just posted about a possible logic issue. I, too, can see the tooltip but I am unable to change my option.

I can test with other characters if required.

MilleXIV commented 8 years ago

So I believe this is the same issue as #43. So should be fixed in latest push. Going to try to knock out a few more bugs before pushing a 2.0.5.