search

MillenniumMachines / RRF-Configs

RepRapFirmware configurations for Millennium Machines
https://diycnc.xyz
GNU General Public License v3.0
3 stars 5 forks source link

Move network configuration above estop.g call #47

Open kohlerj opened 2 weeks ago

kohlerj commented 2 weeks ago

Hi!

I recently added a contactor to my Milo to avoid sending all those amps thru the E-Stop. My contactor has an NO channel which I wired back to my control board (GND and input with pull-up to detect cables brakes as an E-Stop signal).

I took the estop.g.example as an example but I had issues with the M582. Since I do not have a physical RESET button, I could not reset the stack in any other way than pressing the RESET button of the control board or power cycling my machine which I'd like to avoid because of the Pi running, display, etc.

Is there any reason why we cannot configure the network before going into the estop routine? Because then DWC is running and you can trigger the reset from the interface.

https://github.com/MillenniumMachines/RRF-Configs/blob/911d62365ddbf20bacd7c0fda3340f0234dec9a6/milo-v1.5/common/config.g#L18

benagricola commented 1 week ago

Network configuration in RRF doesn't happen at the point where network.g runs. Nothing happens with the network until the configuration is completely loaded, which means reordering the network.g file to be above the optional estop.g wouldn't do anything.

The only thing you can change here is the line in the estop.g file which pauses startup if the estop is active, although removing that line would mean that a restart with the estop pressed would allow the machine to work as normal, which is not good.

kohlerj commented 1 week ago

Hi!Well I did move it above and I have DWC running with the pop up to restart the machine. Which was not the case before. Let me revert it back and test again.Cheers