MillerMark / MrAnnouncerBot

A Twitch bot written in C#
32 stars 13 forks source link

Fanfare Modifications #21

Closed LegendairyMoo closed 5 years ago

LegendairyMoo commented 5 years ago

Hi Mark, Finally got the Fanfare modifications to a place I liked. Some of it goes against the modifications you recently made, yet retains the intended functionality.

Commit highlights

Important Details The change to FileName.cs which holds the path to where you keep the MrAnnouncerBot source code was based upon information you showed in one of your streams. If you move the files or if I have it wrong, you will need to correct the path. Necessary since .NET does not work off of the file in your source repository, it instead copies the file to the run directory and reads from there. Writing to that file would result in the changes being overwritten the next time you started the program. Thus defeating the whole purpose of writing the information in the first place.

Not sure I like the way the enum is written out by the CSV Helper. Feels too open to error when typing it in as part of a csv. A single letter/number probably would be better. Might do that in a future commit.

Hope you like the work done here and thank you so much for showing off the cool stuff you do in the stream.

-moo