search

MillerMark / MrAnnouncerBot

A Twitch bot written in C#
32 stars 13 forks source link

Bug in Emitter #6

Open wilbennett opened 5 years ago

wilbennett commented 5 years ago

There is a bug on line 113 of Emitter.ts... should be calling super.preUpdate() not super.update()..... sorry :(

MillerMark commented 5 years ago

There’s another issue. Particle expiration code isn’t working. Looking into it.

From: wilbennett notifications@github.com Sent: Tuesday, January 1, 2019 12:48 PM To: MillerMark/MrAnnouncerBot MrAnnouncerBot@noreply.github.com Cc: Subscribed subscribed@noreply.github.com Subject: [MillerMark/MrAnnouncerBot] Bug in Emitter (#6)

There is a bug on line 113 of Emitter.ts... should be calling super.preUpdate() not super.update()..... sorry :(

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/MillerMark/MrAnnouncerBot/issues/6, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AEngOKbngj_HnHiIB8ppsxoDe7DbS21Gks5u-61mgaJpZM4Zl_gN.

wilbennett commented 5 years ago

Looks like a merge problem. I'm checking in the fix.