search

MillersvilleCS / MoleculeFlashcardsAndroid

2 stars 0 forks source link

Possible High Score Bug? #3

Closed CMahaff closed 10 years ago

CMahaff commented 10 years ago

Last night I had a bug in my code where it called end_flashcard_game multiple times. It's fixed now, but I think it may have actually added me to the leaderboards 3 times. I couldn't confirm at the time, but looking at the code I don't see why that wouldn't work:

https://github.com/TauferLab/ExSciTecH/blob/master/public_html/src/php/request_types/end_flashcard_game.php

Unless the game_sessions table is cleared after an end-game call somehow I'm not seeing - which in that case would make the table insert fail if the subquery returned nothing?

At the same time, I'm not sure if there is an easy fix for it, server side. Something to be aware of though.

saschlac commented 10 years ago

Thanks for catching that. I'll add the session id to the high score and then verify that there isn't already an entry in the high score table for a given session id.

saschlac commented 10 years ago

Fixed. The server now only stores a single high score for a given game_session_id. https://github.com/TauferLab/ExSciTecH/commit/694d86149ec95392b88de11612db5f829b0d1c13