MillhioreBT / forgottenserver-downgrade

TFS Downgrade 1.5+ is an engine based on nekiro downgrade but highly updated with current tfs code, it also has the lua modules divided and uses lua5.4
GNU General Public License v2.0
19 stars 18 forks source link

Issue with summon after master and summon are killed "at the same time" #7

Closed luanluciano93 closed 11 months ago

luanluciano93 commented 1 year ago

Before creating an issue, please ensure:

Steps to reproduce (include any configuration/script required to reproduce)

  1. I did the test in the task system by getting the task from the demons.
  2. Then I went to orshaball and when he was summoned by a demon, I killed the master and the summon in the same spell hit.
  3. This way, not always, but quite often, the demon summon is counted towards the task system. Note: it was tested only by killing the demon, and it doesn't count as it has the "not master" check

Reproduction environment

I made this video if you need to understand the problem: http://www.mediafire.com/file/ye6lsy8dk7rgd63/ProblemaMatandoSummon.mp4

MillhioreBT commented 1 year ago

A custom task system has nothing to do with this repository.

If it's a script you found on otland, please report it in that script's thread.

luanluciano93 commented 1 year ago

Friend I'm not saying that the error is in the custom script, I said that in any case that you wanted to use only the master, this could be a problem.

if not player or not target or target:getMaster() then return true end

MillhioreBT commented 1 year ago

Friend I'm not saying that the error is in the custom script, I said that in any case that you wanted to use only the master, this could be a problem.

if not player or not target or target:getMaster() then return true end

Sorry for the delay in responding, I will review the case and do some tests, thank you for reporting this problem