search

MillionConcepts / lhorizon

lhorizon helps you find things in the Solar System.
BSD 3-Clause "New" or "Revised" License
5 stars 2 forks source link

Test failure #4

Closed malmans2 closed 3 years ago

malmans2 commented 3 years ago

Hi there,

I've run the tests and I'm getting one failure. I'm using this environment. Here is the log: pytest.log

On a slightly different note: Have you considered a github CI workflow? I've set it up for a few python projects, so I'd be happy to send a PR if that works for you.

https://github.com/openjournals/joss-reviews/issues/3495

m-stclair commented 3 years ago

Sorry, I wasn't getting notifications from this thread.

Test is not taking the value modulo 360! Thank you, I'll fix that.

I have considered it but have never used one. If you'd like to send a PR, that would be great.

m-stclair commented 3 years ago

should be fixed by https://github.com/MillionConcepts/lhorizon/commit/c86f83826710efc0bd927c82b6e9e260dda5305c.