search

MillionConcepts / lhorizon

lhorizon helps you find things in the Solar System.
BSD 3-Clause "New" or "Revised" License
5 stars 2 forks source link

Separate optional from required dependencies #7

Closed malmans2 closed 3 years ago

malmans2 commented 3 years ago

I noticed that a few optional/test dependencies are listed in install_requires: https://github.com/MillionConcepts/lhorizon/blob/b7444036f6df973ba9110bc39b88fef02edc84ca/setup.py#L11-L21

I'd remove those from there and add separate entries (e.g., tests_require and extras_require).

You might want to test both a complete and bare environment in your CI workflow to make sure that everything is working as expected. If you do so, I find this python function quite useful: https://docs.pytest.org/en/6.2.x/reference.html#pytest-importorskip

https://github.com/openjournals/joss-reviews/issues/3495

m-stclair commented 3 years ago

Thank you for these suggestions. I will arrange them.

m-stclair commented 3 years ago

separate optional from required dependencies: a8668e6aa9465d4fbb307eab9b53954f868c3f0c add tests with minimal environment: 3cc0bb2c4ed86af44f20d9071f017603e11ea989