search

MillionConcepts / pdr

[P]lanetary [D]ata [R]eader - A single function to read all Planetary Data System (PDS) data into Python
Other
60 stars 6 forks source link

Support for non-SRC MEX/HRSC images #55

Closed msbentley closed 3 months ago

msbentley commented 3 months ago

HRSC SRC (super resolution camera) images are already supported, but other image types are not:

UserWarning: This product's IMAGE is not yet supported: 'Conventional' line pre/suffixes are not supported for non-BIL multiband images..

Having a quick look I guess this is because of the odd use of BAND_STORAGE_TYPE and BANDS for what is essentially a single-band image (probably coming from the similar way things are defined in VICAR?). In fact if I edit the attached PDS3 label to remove these two lines, pdr loads the image AOK.

An example image: https://archives.esac.esa.int/psa/ftp/MARS-EXPRESS/HRSC/MEX-M-HRSC-3-RDR-EXT9-V4.0/DATA/N998/HN998_0000_ND3.IMG

Alternatively, is there a simple way to modify the meta-data after read and have pdr use these updates, e.g. to remove the offending keywords from the meta-data dictionary?

Thanks for your help!

Sierra-MC commented 3 months ago

Hi Mark,

Just pushed a fix for this to develop commit 26ce78d. You were correct on the diagnosis, we had checks for single band images with claimed multiband properties in other areas of the codebase but were missing one for BIL interleaved images with line prefix/suffixes. Thanks for finding this and pointing out the oversight. The fix will be in our next release (which I'll put out in a couple days, we have a few other things to merge first otherwise I'd push you a new one now).

As for your alternative it has caused us to have a discussion and we are looking into adding a power user feature that will allow changes to the Metadata object to be propagated through to the loader (which will also probably be in the next release with this fix too). So thanks also for the suggestion; you're appreciated!

msbentley commented 3 months ago

Thanks @Sierra-MC for the speedy fix - we'll update when the next release is out! Yes, I can foresee a few cases where it may be useful to modify things on-the-fly, so thanks for considering that use also.

Sierra-MC commented 3 months ago

@msbentley the new release with these changes and the new metadata editing feature is out on pip and conda. See release notes for example usage of the metadata change feature.