search

MillionConcepts / pdr

[P]lanetary [D]ata [R]eader - A single function to read all Planetary Data System (PDS) data into Python
Other
60 stars 7 forks source link

diviner RDRs shouldn't be opened from PDS4 labels #64

Closed m-stclair closed 2 weeks ago

m-stclair commented 3 months ago

Diviner RDRs are stored at GEO as .zip files. PDS4 labels have been generated for these files, but they refer to the 'hypothetical' uncompressed version of the file, and moreover give incorrect case for the actual filename of the file in the ZIP container. pds4-tools does not handle either of these issues. This is reasonable, because they both flagrantly violate PDS4 standards, but still means that pdr cannot read these files using their PDS4 labels. We should include a note in the supported datasets file to load these files only from their PDS3 labels.

michaelaye commented 3 months ago

As info: PDS wanted to unzip and serve them PDS4-conform but realized it would negatively affect server and download times so much that they temporarily agreed on the non conform solution with zipped files while still having the PDS3 labels delivered by the team. they (the PDS) still work on implementing a zipped container into the PDS4 norm.

m-stclair commented 3 months ago

Thank you for the background. That makes sense, and I definitely agree that PDS4 should support a variety of standard compression schema.

Sierra-MC commented 2 weeks ago

Note added in b071a967faa42868527816bdd4e93a8b55d29480