search

MillionConcepts / pdr

[P]lanetary [D]ata [R]eader - A single function to read all Planetary Data System (PDS) data into Python
Other
62 stars 7 forks source link

Change to use actual rms-vax package #65

Closed rfrenchseti closed 1 month ago

rfrenchseti commented 2 months ago

Currently pdr includes an old copy of the RMS Node's vax.py package from the repo SETI/pds-tools (a repo which is now deprecated and mostly empty). This code is out of date. An improved and fully documented version is now available in the rms-vax package available at https://pypi.org/project/rms-vax/

I suggest that pdr be changed to use the current and maintained code rather than having its own copy. If there are features that you need that we don't currently support, please submit an issue on our repo and we will try to help.

Sierra-MC commented 2 months ago

@rfrenchseti thank you for notifying us to this, I appreciate you reaching out and letting us know that there is a supported version. I'll take a look tomorrow and incorporate it appropriately in the coming days.

Sierra-MC commented 1 month ago

Changed to use conda rms-vax package in 5652e38b9af4db46c0df6f5f23b083eb935462f5

Sierra-MC commented 1 month ago

The new release of pdr (1.3.0) uses rms-vax as a dependency.