Miloet / TheManyModsOfLethalCompany

1 stars 2 forks source link

Lightning Rod desync #3

Closed Seviper closed 1 week ago

Seviper commented 2 weeks ago

Tried out your lightning rod mod and while it works perfectly when you are the host, my friends still are susceptible to lightning while carrying scrap. I've attached both the logs from my side and from my friend's side.

LogOutput - Client.log LogOutput - Host.log

For context, I set the price of the lightning rod to 1, and have the config set to where both "Avert Random" and "Avert Targeted" are at 100000 to make sure that lightning never strikes. I as the host never get hit by lightning, and when my friends are carrying scrap, I never see them get hit by lightning either. But the clients see me getting struck by lightning on their side, and when lightning strikes them on their side, they die (as if the lightning rod isn't on).

The reason for this is that I want to set it to a way higher price in my modpack but to guarantee lightning never hits a player when it is on. So I'd love to see if it's possible to achieve that for both host and players.

Miloet commented 2 weeks ago

I see! I think the problem is that the settings are only client sided meaning they require the same settings as you to avoid desync. I will look into it and find a solution. Edit: that was infact not the case, the settings are synced, will continue looking into it

Miloet commented 2 weeks ago

I pushed an update, I am not 100% sure if it will work flawlessly in cases other than yours but it only failed once striking correctly for me which I am pretty sure was because I didn't turn on the machine in time

Lunxara commented 2 weeks ago

I pushed an update, I am not 100% sure if it will work flawlessly in cases other than yours but it only failed once striking correctly for me which I am pretty sure was because I didn't turn on the machine in time

So I was happy to see you updated the mod but noticed it still requires Runtime Netcode Patcher which has been deprecated, I hope to see you hopefully remove that dependency soon ^^

Miloet commented 2 weeks ago

I have not yet found another solution to that unfortunatly :( But on the bright side i believe that the creator deprecated it because they wont be updating it anymore rather than it not working or such.

I pushed an update, I am not 100% sure if it will work flawlessly in cases other than yours but it only failed once striking correctly for me which I am pretty sure was because I didn't turn on the machine in time

So I was happy to see you updated the mod but noticed it still requires Runtime Netcode Patcher which has been deprecated, I hope to see you hopefully remove that dependency soon ^^

— Reply to this email directly, view it on GitHub https://github.com/Miloet/TheManyModsOfLethalCompany/issues/3#issuecomment-2106407224, or unsubscribe https://github.com/notifications/unsubscribe-auth/AO6CQPCPKRQCEBNJJJBNX73ZB72NZAVCNFSM6AAAAABHTDMQAGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBWGQYDOMRSGQ . You are receiving this because you commented.Message ID: @.***>

Seviper commented 2 weeks ago

Apologies, that was a misclick. Just wanted to comment my update on the desync. The good news is that replicating the situation with just the mod by itself has fixed the desync! The less good news is that once I put it into my modpack, the desync reappeared, aha. I'll be doing more testing this week to see if I can pin down what may be causing some conflicts. Thanks for the swift fix today!

Miloet commented 2 weeks ago

Once you find which mod, or mods, that cause the bug ill attempt to replacate and fix it

Seviper commented 1 week ago

Howdy! Sorry for such a long reply time.

LC modding has the same logic that makes car engines work when you sit down to actually try fixing something... the mod mysteriously works now within the same modpack from before. I'm cautiously optimistic with stating the desync issue may be okay for now. If a new one pops up, I'll be sure to send you the logs and try testing it again. There is a different issue I've noticed while using the mod however, so I'll open up a different post for it. Thank you for your patience!