Mimieam / TabSorter2

Google Chrome Tab Management Extension - Merge, Sort, split and more :) - https://chrome.google.com/webstore/detail/tabsorter2/lmmmdnmgmgnimgcfbnomdgeldehlfafn

https://www.tabsorter2.com

65 stars 9 forks source link

some of the buttons do nothing #18

Closed jeisner closed 4 years ago

jeisner commented 5 years ago

Some of the buttons work as advertised, but many of them seem to have no effect.
Am I the first to report this? Is there any information I can provide that will help you fix it?

(Note: I'm using Linux, but I'm not sure how that would explain the pattern of non-functionality.)

Mimieam commented 5 years ago

Hi @jeisner, using linux shouldn't affect the functionalities. There is a known chrome bug with getting the current window id, I'm writing a workaround and will push it in the next release :)

nstielau commented 5 years ago

Great tool! I'm on Fedora 29. For me, the Options and Deduplicate Current do not work.

Mimieam commented 4 years ago

Ok So this took much longer than anticipated to reproduce and figure out what was going on here. I primarily developed this app on a laptop with 1 monitor. so this chrome bug was never noticed.

So it turns out, that those buttons actually works - that is the JS behind is correctly triggered - but the css animation does not and this seems to be linked to having multiple monitors

The max height of a chrome extension is 600px This chrome/CSS bug happens when a clicking a button below 350px from a window on a secondary monitor.

I will be filling another chrome bug - there isn't much i can do here since this is a native CSS issue that affects multiple extensions.

I will close this for now but if I have missed anything, feel free to reopen this :)

nstielau commented 4 years ago

hero #probablyChomesFault #opensource #fridaynight #thanks!

On Fri, Nov 8, 2019, 6:31 PM A. Miezan Echis notifications@github.com wrote:

Closed #18 https://github.com/Mimieam/TabSorter2/issues/18.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/Mimieam/TabSorter2/issues/18?email_source=notifications&email_token=AAAHKO5Z45BOQXQAOOQX2ALQSYOJHA5CNFSM4HEDSAM2YY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOUX76N4Q#event-2785011442, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAHKOZIDTA5KXKOZ2RZUKTQSYOJHANCNFSM4HEDSAMQ .