MinBZK / Algoritmekader

Het ministerie van BZK gaat aan de slag met een Algoritmekader. Het doel daarvan is om overheden op praktische wijze te ondersteunen, zodat zij op een wettige en ethisch verantwoorde wijze algoritmes en AI-systemen gebruiken.
https://minbzk.github.io/Algoritmekader/
European Union Public License 1.2
25 stars 18 forks source link

Add PoC shopping cart functionality #154

Open rubenrouwhof opened 2 months ago

rubenrouwhof commented 2 months ago

Beschrijf jouw aanpassingen

Bij welk issue hoort deze pull-request?

https://github.com/orgs/MinBZK/projects/7?pane=issue&itemId=60943660

Checklist before requesting a review

github-actions[bot] commented 2 months ago

PR Preview Action v1.4.7 :---: :rocket: Deployed preview to https://MinBZK.github.io/Algoritmekader/pr-preview/pr-154/ on branch gh-pages at 2024-07-04 12:18 UTC

laurensWe commented 2 months ago

2 things i saw was that:

ruthkoole commented 2 months ago

2 things i saw was that:

* you need to refresh on the maatregelen page before the maatregelen gets listed down

* if you refresh while you have items in your shopping basket you will end up with an empty shopping basket (but this is fine for a PoC i recon).

In the preview the maatregelen table is empty? https://minbzk.github.io/Algoritmekader/pr-preview/pr-154/maatregelen/#maatregelen

laurensWe commented 2 months ago

2 things i saw was that:

* you need to refresh on the maatregelen page before the maatregelen gets listed down

* if you refresh while you have items in your shopping basket you will end up with an empty shopping basket (but this is fine for a PoC i recon).

In the preview the maatregelen table is empty? https://minbzk.github.io/Algoritmekader/pr-preview/pr-154/maatregelen/#maatregelen

hmm yeah indeed, locally when testing with mkdocs serve it will show the maatregelen after a refresh but not in the preview :s

rubenrouwhof commented 2 months ago

@laurensWe @ruthkoole I looks like it isnt visible in preview because it looks for the json in Algoritmekader/pr-preview/maatregelen.json but the file is Algoritmekader/docs/maatregelen.json. Thats why it is visible on your local. Any idea how to fix it?

rubenrouwhof commented 2 months ago

2 things i saw was that:

  • you need to refresh on the maatregelen page before the maatregelen gets listed down
  • if you refresh while you have items in your shopping basket you will end up with an empty shopping basket (but this is fine for a PoC i recon).

@laurensWe I have tried to fix both, can you check on your machine? Table is visible on http://localhost:8000/maatregelen/

ruthkoole commented 2 months ago

@laurensWe @ruthkoole I looks like it isnt visible in preview because it looks for the json in Algoritmekader/pr-preview/maatregelen.json but the file is Algoritmekader/docs/maatregelen.json. Thats why it is visible on your local. Any idea how to fix it?

Hm. Must be something wrong with creating the URL in the python script. I now realize that I have seen this error before. I will have a look at it. Apparently it works when running locally, but it does not work in the preview...

laurensWe commented 2 months ago

2 things i saw was that:

  • you need to refresh on the maatregelen page before the maatregelen gets listed down
  • if you refresh while you have items in your shopping basket you will end up with an empty shopping basket (but this is fine for a PoC i recon).

@laurensWe I have tried to fix both, can you check on your machine? Table is visible on http://localhost:8000/maatregelen/

I saw that you fixed it when refreshing the page, but the first time i enter /maatregelen it is still empty though the page