MinaFoundation / PGT_govbot

Discord bot for collective decision making
MIT License
3 stars 2 forks source link

Scenario 11-11.1: Submit proposal to a funding round / Scenario 11.2: Manage submitted proposals #15

Closed CristinaEche closed 14 hours ago

CristinaEche commented 1 month ago

Scenario 11: Submit proposal to a funding round

Entry points: propose channel, submit proposal to a funding round, drop down list

User Story As a Community member I want to Submit a proposal to a funding round So that it can be considered for funding

Make sure the proposal is complete with all the requested info is updated

Acceptance criteria OK Given that I executed the Submit proposal to a Funding Round button, selected a proposal and selected funding round name When I execute the Confirm Submission button Then The proposal should be added to the funding round successfully

KO Given that I have no draft proposals in my list When I use the Submit Proposal button Then The system should return an error message indicating the failure to add the proposal to the funding round

-

Scenario 11.1: Submit proposal to a funding round from manage drafts option

Entry points: propose channel, manage drafts, drop down list

User Story As a Community member I want to submit a recently created proposal to a funding round So that it can be considered for funding.

Acceptance criteria Given A selected proposal from the list, When I execute the button submit to funding round, Then I have to select the funding round and click on the confirm submission button, my proposal should be submitted successfully and a confirmation message will be shown

KO only if the proposal cannot be added for any unknown reason

-

Scenario 11.2: Manage submitted proposals

Entry points: propose channel, Manage my proposals, & drop down list, or from a recently added proposal & drop down list

User Story As a Community member I want to cancel a submitted proposal So that its removed from the funding round

Please notice that submitted proposals cannot be Edited.

Acceptance criteria Given that I clicked on the Manage Proposal button, selected funding round and selected proposal from the list When I execute the button Cancel Proposal, Then a Confirm Cancellation button is presented, I can cancel or go back. If Go back or dismiss message proposals are not canceled. If Confirm cancellation the proposal is canceled and removed from the funding round, a successful confirmation message is presented

User type: Community member submitting the proposal - proposal channel

remigiusz-antczak commented 1 month ago

Scenario 11: Submit a proposal to a funding round

KO Given that I have no draft proposals in my list When I use the Submit Proposal button Then, The system should return an error message indicating the failure to add the proposal to the funding round

I tried to submit a proposal to a funding round, but I don't have any proposals drafted yet, and I received a correct response: ℹ️ You have no draft proposals to submit.

image
remigiusz-antczak commented 1 month ago

Scenario 11.0.5 (?) (I think we're missing this scenario): Create a new proposal, edit, remove Entry points: propose channel, manage drafts, drop-down list

Edit: This is actually already covered in https://github.com/MinaFoundation/PGT_govbot/issues/12

User Story 1 As a Community member I want to create a proposal (that I could later submit to a funding round) So that it can be considered for funding.

Acceptance criteria OK Given that I executed the Create New Proposal button, I must provide the required details (PROPOSAL NAME, BUDGET, and URL) When I execute the Submit button Then, the proposal should be created successfully

KO if I dismiss the pop-up modal without providing the required details, I will lose the proposal creation without any warning message

User Story 2 As a Community member I want to edit created proposals So that I can adjust it to increase my chances of getting funding.

Acceptance criteria OK Given that I executed the Manage Drafts button and selected a proposal from the drop-down list When proposal details are presented, I can click on the Edit Proposal button Then, I can adjust the proposal in a pop-up modal, click the Submit button, and successfully update the proposal.

KO if I dismiss the pop-up modal without providing the required details, I will lose the proposal creation without any warning message

User Story 3 As a Community member I want to remove created proposals So that I can delete the ones I no longer need.

Acceptance criteria OK Given that I executed the Manage Drafts button and selected a proposal from the drop-down list When proposal details are presented, I can click on the Delete Proposal button Then, I can click the Confirm Delete button and successfully remove the proposal

KO if I click the Cancel button, I will be redirected to a previous view without any warning message

I successfully executed all the above scenarios in one video. Everything works correctly.

Proof:

https://github.com/user-attachments/assets/b732e862-5f89-4720-a860-45d5589571d3

Comments:

  1. I suggest updating the user after editing a proposal. The proposal view is not updated (after editing it), and the user is required to open it again. But the user doesn't know about it because there's no update or notification. Please verify if this can be improved to make sure users understand.
remigiusz-antczak commented 1 month ago

Scenario 11.1: Submit proposal to a funding round from manage drafts option

Entry points: propose channel, manage drafts, drop down list

User Story As a Community member I want to submit a recently created proposal to a funding round So that it can be considered for funding.

Acceptance criteria Given A selected proposal from the list, When I execute the button submit to funding round, Then I have to select the funding round and click on the confirm submission button, my proposal should be submitted successfully and a confirmation message will be shown

KO only if the proposal cannot be added for any unknown reason

I successfully managed to submit a proposal to a funding round (also reviewed cancelling options and they work correctly, too, more details in the proof video):

image

Proof:

https://github.com/user-attachments/assets/b1ae491b-5137-4442-b938-53bf28f38ce2

remigiusz-antczak commented 1 month ago

Scenario 11.2: Manage submitted proposals

Entry points: propose channel, Manage my proposals, & drop-down list, or from a recently added proposal & drop-down list

User Story As a Community member I want to cancel a submitted proposal So that it's removed from the funding round

Please note that submitted proposals cannot be edited.

Acceptance criteria Given that I clicked on the Manage Proposal button, selected funding round and selected proposal from the list When I execute the button Cancel Proposal, Then a Confirm Cancellation button is presented, I can cancel or go back. If Go back or dismiss message proposals are not canceled. If Confirm cancellation the proposal is canceled and removed from the funding round, a successful confirmation message is presented

User type: Community member submitting the proposal - proposal channel

I successfully managed to cancel a proposal:

image

Proof:

https://github.com/user-attachments/assets/fd34074f-3c7d-49c3-b83d-b72d5f356237

Comments:

  1. Unify Cancel buttons - When clicking the Cancel button while canceling a proposal, I'm not redirected to the previous view. Instead, an error message is displayed. Please review if we could unify how Cancel buttons behave across the whole platform to keep it consistent and avoid confusing people. More details are available in the Proof video above.
    • image
  2. Remove the Cancel My Proposal button when the proposal has already been canceled —When canceling a proposal, users can go back to their proposals and see the canceled one with an inactive button to cancel it. Since it's already been canceled, please review whether we can hide this button to avoid confusing users.
    • image
CristinaEche commented 14 hours ago

Tested the scenarios with community people:

A proposal if deleted from the forum cannot be canceled from user action to withdraw the proposal from the funding round.

Will add this to the list of bugs in another Issue.