search

MinaProtocol / mina

Mina is a cryptocurrency protocol with a constant size blockchain, improving scaling while maintaining decentralization and security.
https://minaprotocol.com
Apache License 2.0
1.97k stars 523 forks source link

Write tests for Zkapp_command_logic. #12530

Open Sventimir opened 1 year ago

Sventimir commented 1 year ago

The module src/lib/transaction_logic/mina_transaction_logic.ml contains almost 2000 lines of the most basic operations needed for executing ZK app commands. It's used in 2 places: src/lib/transaction_logic/mina_transaction_logic.ml and also in src/lib/transaction_snarks.ml. We need to write tests for this module, because currently there are none. This is a groundwork module and it definitely should be tested thoroughly.

Modules to be tested:

Sventimir commented 1 year ago

More tests for the entirety zkApp command logic are being added by #12795. Tests for specific submodules and functions still need to be written.

Sventimir commented 1 year ago

12795 has been closed, as it targets develop, while these changes should really go to berkeley. #13009 has been opened instead.