Open dkijania opened 8 months ago
Agreed flow with Matthew how was a reviewer of my pr:
Design include two jobs with relations
version linter
depends on version linter setup
if shapes file exists, copy it from bucket to buildkite cache
if shapes file doesn't exist, git fetch origin && git checkout origin/$UPSTREAM_BRANCH, then build and upload the shapes file and copy it to buildkite cache
version linter job:
depends on version linter setup job by the time it runs, we know the shapes file has been uploaded, so we can confidently use it without experiencing flakes
more so for dev work improvement --- unclear where this is until he's back
Another evidence of version linter job flakiness:
Last commit on develop branch didn't generate reference version linter: https://github.com/MinaProtocol/mina/commit/da2e21fc2a85cc20b1acf9a516b045a4bfeb6ba2 job get skipped because the changes were outside dirtyWhen condition which triggers this build
Ideas how to solve it: