search

MinaProtocol / mina

Mina is a cryptocurrency protocol with a constant size blockchain, improving scaling while maintaining decentralization and security.
https://minaprotocol.com
Apache License 2.0
1.97k stars 523 forks source link

[berkeley] Remove stop-slots from compile config #15589

Open mrmr1993 opened 2 months ago

mrmr1993 commented 2 months ago

This PR removes the stop slots from the compile config.

These caused a previous issue where a release was baked expecting it to use the compile config, where CI is not set up to do so. Instead, we remove the options so that they are only injected in the correct location: in the runtime config that we provide for the network.

mrmr1993 commented 2 months ago

!ci-build-me

georgeee commented 2 months ago

Is this change necessary in berkeley?

It looks safe and sane, but I'd prefer to avoid any changes to berkeley unless we're confident they're necessary.

As for these changes, I suggest we merge them to develop and on berkeley reject any PR that touches compile configs (including touching the stop slots).