MinaProtocol / mina

Mina is a cryptocurrency protocol with a constant size blockchain, improving scaling while maintaining decentralization and security.
https://minaprotocol.com
Apache License 2.0
1.97k stars 523 forks source link

Promote kimchi_backend_common and kimchi_pasta #15630

Closed georgeee closed 1 week ago

georgeee commented 1 month ago

Promote these two sublibraries to be packages of their own. This allows to remove three-layered sublibrary names.

More importantly, it removes some package-to-package circular dependencies and overall makes things a bit cleaner.

Clarification

It's package-to-package circular dependency, not libray-to-library. Dune handles it well. But dependency diagram becomes way less readable, also it makes packages incompatible with findlib-based installation approach (because one can't install packages one by one, they depend on one other).

Explain how you tested your changes:

Checklist:

georgeee commented 1 month ago

!ci-build-me

georgeee commented 2 weeks ago

!ci-build-me