MinaProtocol / mina

Mina is a cryptocurrency protocol with a constant size blockchain, improving scaling while maintaining decentralization and security.
https://minaprotocol.com
Apache License 2.0
1.97k stars 523 forks source link

Do not call ocamlformat from dune #15632

Open georgeee opened 1 month ago

georgeee commented 1 month ago

It's a trick that doesn't seem to be necessary and isn't the cleanest one.

Explain how you tested your changes:

Checklist:

dannywillems commented 1 month ago

There is a more elegant solution which is using built-in fmt in dune, with dune fmt, and get rid of reformat. Source: https://ocaml.org/docs/formatting-your-code