MinaProtocol / mina

Mina is a cryptocurrency protocol with a constant size blockchain, improving scaling while maintaining decentralization and security.
https://minaprotocol.com
Apache License 2.0
1.97k stars 522 forks source link

PEERS_LIST_URL vs PEER_LIST_URL #15680

Open kaozenn opened 1 month ago

kaozenn commented 1 month ago

Preliminary Checks

Description

In https://github.com/MinaProtocol/mina/blob/fda6cb8291cb155002c159ce9448012ac33f04ce/scripts/mina.service#L8C14-L8C28

PEER_LIST_URL url is referred as PEERS_LIST_URL This is not a blocker but the documentation refers PEER_LIST_URL as PEERS_LIST_URL

PEER_LIST_URL can be interpreted by the mina daemon but PEERS_LIST_URL is not

I believe we should align PEER_LIST_URL

Steps to Reproduce

  1. Install any debian version of the mina daemon
  2. Look at the mina.service systemd file or alternatively refer to this file
  3. Look at the reference of PEER_LIST_URL and PEERS_LIST_URL in the official documentation ...

Expected Result

We should only have PEER_LIST_URL referred across the mina packages and the documentation

Actual Result

PEERS_LIST_URL is referred in the documentation (.mina-env) but fails as PEER_LIST_URL is expected instead

Daemon version

All of them

How frequently do you see this issue?

Always

What is the impact of this issue on your ability to run a node?

Low

Status

Mina daemon does not start if `PEERS_LIST_URL` is defined as per as the documentation

Additional information

This issue occurs when trying to align the documentation between Debian and Docker