search

MinaProtocol / mina

Mina is a cryptocurrency protocol with a constant size blockchain, improving scaling while maintaining decentralization and security.
https://minaprotocol.com
Apache License 2.0
1.97k stars 522 forks source link

Fix remaining warnings on `develop` related to Pickles #15684

Closed rbonichon closed 1 month ago

rbonichon commented 1 month ago

The 'fp and 'fp_opt type variables have become unused after the last changes.

This is an updated version of https://github.com/MinaProtocol/mina/pull/14080

rbonichon commented 1 month ago

!ci-build-me

rbonichon commented 1 month ago

!ci-build-me

rbonichon commented 1 month ago

!ci-build-me

rbonichon commented 1 month ago

!ci-build-me

rbonichon commented 1 month ago

After talking with @mrmr1993, this needs further checks as changing type declarations in mina_wire_types might affect the protocol layer by producing different encodings. As of now, develop needs to stay compatible with berkeley: short of testing whether there is any effect, this PR potentially breaks the aforementioned requirement for compatibility.

Closing for now.