MinaProtocol / mina

Mina is a cryptocurrency protocol with a constant size blockchain, improving scaling while maintaining decentralization and security.
https://minaprotocol.com
Apache License 2.0
1.97k stars 522 forks source link

Add suffix to docker version if we are building instrumented dockers #15749

Closed dkijania closed 1 week ago

dkijania commented 2 weeks ago

We are not distinguishing instrumented docker in CI. This PR is adding -instrumented suffix to a daemon and archive docker

dkijania commented 2 weeks ago

!ci-build-me

georgeee commented 1 week ago

@dkijania could you add info on how was this change tested? In particular, I'm interested in confirmations:

dkijania commented 1 week ago

@georgeee Apologies for not providing this information earlier. I tested instrumented dockers manually by:

  1. pulling instrumented image: docker pull gcr.io/o1labs-192920/mina-daemon:785dbcf-bullseye-berkeley-instrumented
  2. executing bash interactively: docker run -it --entrypoint bash gcr.io/o1labs-192920/mina-daemon:785dbcf-bullseye-berkeley-instrumented
  3. executing some command to trigger coverage files dump: mina internal
  4. examining working dir: ls *.coverage

The same test for non-instrumented dockers but effect should be no coverage files. I performed such test for all combination of dockers for daemon and archive node

dkijania commented 1 week ago

!ci-build-me

dkijania commented 1 week ago

!ci-build-me