MinaProtocol / mina

Mina is a cryptocurrency protocol with a constant size blockchain, improving scaling while maintaining decentralization and security.
https://minaprotocol.com
Apache License 2.0
1.99k stars 529 forks source link

Remove the need for patch checks in CI #15791

Closed martyall closed 3 months ago

martyall commented 3 months ago

We currently have a check_patches job that runs the following script:

#!/bin/bash

set -e

function both() { git apply $1 && git apply -R $1; }
both scripts/hardfork/localnet-patches/berkeley.patch
both buildkite/scripts/caqti-upgrade.patch
both buildkite/scripts/caqti-upgrade-plus-archive-init-speedup.patch

It is currently breaking CI for my other branch #15779 and from the standup discussion we should just be merging the changes and removing this check

martyall commented 3 months ago

actually it seems like this was already done https://github.com/MinaProtocol/mina/commit/0615bf06ee6d0d4228044e3b91073c2d291054b7, at least for merges with compatible