search

MinaProtocol / mina

Mina is a cryptocurrency protocol with a constant size blockchain, improving scaling while maintaining decentralization and security.
https://minaprotocol.com
Apache License 2.0
1.99k stars 527 forks source link

Benchmark dev-unit tests with lagrange basis caching #15847

Open martyall opened 2 months ago

martyall commented 2 months ago

now that we have #15843 we would like to understand the impact on CI speedup times. There may be more we can do here because I am not always seeing the speedups we expected.

martyall commented 2 months ago

looking at the times for the dev-unit-test job, with caching we are seeing 24m41s up to 31m35s, whereas a recent compatible nightly is running for 37m30s

Just one data point in either case and I don't know if the nightly tests agent is somehow different. For another comparison point, here is a recent PR to compatible running in 40m22s

@mrmr1993 I have a solution for #15846. I'm going to try to benchmark it against this, but my feeling is that unless you noticeably gain something there we should not even bother -- depending on the results it may better to keep it in this simple state rather than managing more code/complexity IMO.