search

MinaProtocol / mina

Mina is a cryptocurrency protocol with a constant size blockchain, improving scaling while maintaining decentralization and security.
https://minaprotocol.com
Apache License 2.0
1.99k stars 529 forks source link

dummy values hot fix #15900

Closed martyall closed 2 months ago

martyall commented 2 months ago

The dummy functions are using a global "random oracle" module in which all the modules are sharing the same pseudorandom number generator. Before, dummy_values.ml was generated at compile time hence wasn't competing for a given seed state with the other functions. This PR restores that

NOTE: We should definitely get rid of the global random oracle state in follow up work. I'm surprised it hasn't caused more problems in the past -- in theory the order in which you run the tests can break them

martyall commented 2 months ago

!ci-build-me

georgeee commented 2 months ago

Closed in favor of #15901