the mina_signature_kind library provides a kind of compile time configuration that is as brittle as the mlh configuration we are working to remove. The usage of
unnecessarily duplicates the codebase's executables in several places:
src/app/cli/src/mina.exe splits into src/app/cli/src/mina_{testnet, mainnet}_signatures.exe
src/app/archive/archive.exe splits into src/app/archive/archive_{testnet, mainnet}_signatures.exe
src/app/rosetta/rosetta.exe splits into src/app/rosetta/rosetta_{testnet, mainnet}_signatures.exe
src/app/rosetta/ocaml-signer/signer.exe splits into src/app/rosetta/ocaml-signer/signer_{testnet, mainnet}_signatures.exe
As we move away from compile time configuration, it as also possible to mix runtime configuration from one network with one of these builds in a way that it incoherent. I would propose that we
remove the signature_kind package(s)
remove the relevant sum type to mina_compile_config and make signature_kind a field there
remove all of these duplicated executables and supply proper configuration for the remaining one
the
mina_signature_kind
library provides a kind of compile time configuration that is as brittle as themlh
configuration we are working to remove. The usage ofsrc/lib/signature_kind/testnet/mina_signature_kind.ml
src/lib/signature_kind/mainnet/mina_signature_kind.ml
unnecessarily duplicates the codebase's executables in several places:
src/app/cli/src/mina.exe
splits intosrc/app/cli/src/mina_{testnet, mainnet}_signatures.exe
src/app/archive/archive.exe
splits intosrc/app/archive/archive_{testnet, mainnet}_signatures.exe
src/app/rosetta/rosetta.exe
splits intosrc/app/rosetta/rosetta_{testnet, mainnet}_signatures.exe
src/app/rosetta/ocaml-signer/signer.exe
splits intosrc/app/rosetta/ocaml-signer/signer_{testnet, mainnet}_signatures.exe
As we move away from compile time configuration, it as also possible to mix runtime configuration from one network with one of these builds in a way that it incoherent. I would propose that we
signature_kind
package(s)mina_compile_config
and makesignature_kind
a field there