search

MinaProtocol / mina

Mina is a cryptocurrency protocol with a constant size blockchain, improving scaling while maintaining decentralization and security.
https://minaprotocol.com
Apache License 2.0
2k stars 528 forks source link

Fix promotion job PUBLISH misuse #16306

Closed dkijania closed 1 month ago

dkijania commented 1 month ago

Fixes promotion job logic.

PUBLISH flag controls whether we push docker image to gcr or docker.io. We were testing existance of PUBLISH variable only, which looks like and issue as if we don't want to publish to docker.io we set PUBLISH=0. However, code check only if variable is set not its value. Therefore we promote it to docker.io even if our target was gcr.io. This pr fixes is by comparing PUBLISH value

dkijania commented 1 month ago

!ci-build-me

dkijania commented 1 month ago

Promotion job: https://buildkite.com/o-1-labs-2/promote-package/builds/231#0192d903-1c13-4e76-a612-c7baf599c12a

deepthiskumar commented 1 month ago

!approved-for-mainnet