search

Minamirb / benten

Benten is a realtime chat application powerd by rails4 made at the time of the Okinawa Rails Hackathon 2012.
MIT License
3 stars 3 forks source link

Feature / Twitter Bootstrap Rails on Rails4 #5

Closed meltedice closed 11 years ago

meltedice commented 11 years ago

Added twitter-bootstrap-rails and slim-rails.

It seems working well.

Can we use twitter-bootstrap with this project?

yalab commented 11 years ago

TwitterBootstrap is good. We need it.

When I pointed out one thing, pull request has only one issue is better. Install twitter-bootstrap is ok, install slim is ok(but I don't like slim), because those of gems are about design. But install dispatcher.js and generate Webrtc is unneccesary.

Or did you forget to switch branches after pull request?

meltedice commented 11 years ago

Sorry for that my pull request including different issues.

This time, I just forgot to switch branches. Next time, I put ONE issue into ONE pull request.

About template engines, which template engine shall we use? I prefer haml or slim. I don't like erb. But it's better to choose one template engine for one project. So if we choose erb, I'll use erb.

BTW. The features I put into this pull request are just example codes. So you can ignore. If need to split this pull request into some pull requests, I'll do it for my github experience.

Thanks!

meltedice commented 11 years ago

One pull request with one issue! One pull request with one issue!! One pull request with one issue!!! One pull request with one issue!!!!