search

Mincka / DMArchiver

A tool to archive the direct messages, images and videos from your private conversations on Twitter
GNU General Public License v3.0
222 stars 25 forks source link

-di and -dg aren't grabbing anything with this latest release (win x86-64) #17

Closed Mincka closed 7 years ago

Gorrrg commented 7 years ago

I think #16 is related. I think the problem is with the #14 fix. Text messages are put under DirectMessage-contentContainer but all other types of messages are still booked under DirectMessage-container? After the fix only the class DirectMessage-contentContainer is crawled for elements.

Gorrrg commented 7 years ago

Ok, so the hierarchy is as follows. DirectMessage-container is the parent, and under it there's elements like DirectMessage-media u-borderRadiusInherit u-chromeOverflowFix for images and DirectMessage-contentContainer specifically for the text element DirectMessage-text.

I think the best solution would be to roll the code back to before the #14 fix, and in the for-loop instead of matching DirectMessage-text match for DirectMessage-contentContainer. If that is matched create another sub for-loop that verifies there's a DirectMessage-text in it (or else it's "Unknown element").

Gorrrg commented 7 years ago

No actually, come to think of it that won't work. Now DirectMessage-container can have multiple elements in one message that are of importance. For instance if an image was sent with a description.

Mincka commented 7 years ago

Thank you for looking into it. Indeed, I didn't check completely the proposed fix and few issues are still there.

As I can see now, we have:

Mincka commented 7 years ago

It seems I've managed to make a proper fix without too much effort.

Could you test this release before I push the commit please? Again thanks a lot for your help and your interest in the project. It is a motivation to improve and fix the tool. 😃

dmarchiver-0.1.3-windows-x86-64.zip

goofyhsk commented 7 years ago

di and dg looking great now

I've noticed originally (I started using with 0.1.1) I had 38 conversation txts, now I only get 19 with 0.1.2, 0.1.3

(I count about 37 on the twitter site still)

Mincka commented 7 years ago

Thanks for the feedback. Another interesting issue. Are the retrieved conversations the 19 most recent ones? This may be related to #8 but starting with 20 conversations instead of 50.

goofyhsk commented 7 years ago

Can confirm that, 19 most recent.

sussron commented 7 years ago

Hi Julien,I pasted this on the Fix #17 but realize it's closed and perhaps you wont' see it. so maybe i should email the issue here. I wasn't sure, so i'm sorry for sending it to you twice.:

Hi Julien, I've downloaded the most recent release 1.3 as I hadn't backed up messages since February. I decided to do just one of the conversations with images. I i put in the commands as you showed me (remember I'm not the techie one here so i apologize for my ignorance) . i'm still getting the Unknown element error that other users mentioned in prior threads. it is still processing tweets, but what is it not including so that I'm sure what i'm getting? Thanks in advance for your help

Thanks, Ronnie

PS. the resulting txt file had pulled 175000 messages but it's just the date and username and not the actual text messages that were typed.

On Sat, Jun 24, 2017 at 10:59 AM, goofyhsk notifications@github.com wrote:

Can confirm that, 19 most recent.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Mincka/DMArchiver/issues/17#issuecomment-310843439, or mute the thread https://github.com/notifications/unsubscribe-auth/AVxObrft2ctbyq4MAAI422K2qcEMorvcks5sHSRfgaJpZM4OBa00 .

sussron commented 7 years ago

And julien, I compared it to the file from February which was 18.5MB whereas this empty one is 6.5MB in size. the images folder has only 15 stickers in it and not the actual message images. I'm attaching screen shots for you to compare. Also the date of the message goes back to 8/5/15 as the attachment shows, but the file that came this time started 12/5/15.

Thanks so much! Ronnie

On Sat, Jun 24, 2017 at 7:01 PM, Ronnie Sussman sussron@gmail.com wrote:

Hi Julien,I pasted this on the Fix #17 but realize it's closed and perhaps you wont' see it. so maybe i should email the issue here. I wasn't sure, so i'm sorry for sending it to you twice.:

Hi Julien, I've downloaded the most recent release 1.3 as I hadn't backed up messages since February. I decided to do just one of the conversations with images. I i put in the commands as you showed me (remember I'm not the techie one here so i apologize for my ignorance) . i'm still getting the Unknown element error that other users mentioned in prior threads. it is still processing tweets, but what is it not including so that I'm sure what i'm getting? Thanks in advance for your help

Thanks, Ronnie

PS. the resulting txt file had pulled 175000 messages but it's just the date and username and not the actual text messages that were typed.

On Sat, Jun 24, 2017 at 10:59 AM, goofyhsk notifications@github.com wrote:

Can confirm that, 19 most recent.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Mincka/DMArchiver/issues/17#issuecomment-310843439, or mute the thread https://github.com/notifications/unsubscribe-auth/AVxObrft2ctbyq4MAAI422K2qcEMorvcks5sHSRfgaJpZM4OBa00 .