search

MincraftEinstein / SubtleEffects

Adding many new subtle details through particles and a few sounds
29 stars 3 forks source link

Configs Registration Timing + ModMenu #31

Closed fzzyhmstrs closed 2 weeks ago

fzzyhmstrs commented 2 weeks ago

ModMenu asks for config screen factories early (earlier than it should IMO). So if configs are loaded too "lazily", they may be loaded after MM asks for them. This appears to be happening with Subtle Effects.

Two possible solutions:

  1. It appears that you have a static init() method in ModConfigs, but don't actually call it. Calling it in a mod initializer may move config generation early enough.
  2. If it doesn't, you can add to the mod metadata to alert Fzzy Config of a config scope that it should give to ModMenu. Link: https://github.com/fzzyhmstrs/fconfig/wiki/Troubleshooting#config-not-in-modmenu

ModMenu integration problem replicated from https://github.com/fzzyhmstrs/fconfig/issues/23

fzzyhmstrs commented 2 weeks ago

Here is the timing of ModMenu and SubtleEffects in a log: image

MincraftEinstein commented 2 weeks ago

Oh, I meant to call the init method, that will probably fix it. Thanks