search

MindBuffer / smode_laser_plugin

Smode plugin for sending streams to LASER projectors
2 stars 2 forks source link

Point to release build of `smode_laser` Rust library #18

Closed mitchmindtree closed 4 years ago

mitchmindtree commented 4 years ago

Currently we're still linking to the debug build of the static library for testing. We should make sure we're pointing to the release build before we consider this finished. Alternatively, maybe there's some way to select between the two in cmake depending on the target being built?

francis-maes commented 4 years ago

Assigning @Qlex42, because he will be able to help you on Cmake stuff

mitchmindtree commented 4 years ago

Ahh that would be great! This is the line in the CMakeLists where we currently assume debug. @Qlex42 I wonder if we should check some condition here to select between debug or release static lib instead?

Qlex42 commented 4 years ago

Hi Mitch !

CMake offer special TARGET_LINK_LIBRARIES parameters (debug and optimized) for that:

target_link_libraries(Laser debug "${PLUGIN_DEBUG_LIB_PATH}/smode_laser.lib" optimized "${PLUGIN_RELEASE_LIB_PATH}/smode_laser.lib")

hoping this can helps

mitchmindtree commented 4 years ago

Perfect, thanks @Qlex42 !