search

MindBuffer / smode_laser_plugin

Smode plugin for sending streams to LASER projectors
2 stars 2 forks source link

Test the `add_points` functionality #23

Closed mitchmindtree closed 4 years ago

mitchmindtree commented 4 years ago

So far we've only tested the add_lines functionality as this is what we are currently provided with from the LaserGeometryRenderer. We should double check that add_points works just as well.

francis-maes commented 4 years ago

I was thinking that if this transformation is required by every laser, it should probably be handled on the LaserGeometryRenderer side (this enable to expose any property we want in the process of creating the final sequence of laser points, and this makes the "device" part simpler). Open to discussion :)

mitchmindtree commented 4 years ago

Yes that is totally fine. In the Rust code, we actually implement add_points in terms of add_lines as points are just lines that start and end in the same position with blank lines between them. Here is where we implement add_points in the Rust code in case you are interested.

francis-maes commented 4 years ago

As discussed together, let's close this one and push this question to the LaserGeometryRenderer.