search

MindFlavor / prometheus_wireguard_exporter

A Prometheus exporter for WireGuard, written in Rust.
https://mindflavor.github.io/prometheus_wireguard_exporter
MIT License
493 stars 51 forks source link

Dockerize the app! #39

Closed qdm12 closed 4 years ago

qdm12 commented 4 years ago

I'm a bit of a Docker maniac and like to run everything in containers (even iptables, not kidding!)

There are just 3 points we should address:

  1. Maybe we can move that Docker section somewhere else in the readme
  2. Do you have a Docker Hub account? If so, I can set up some Docker build pipeline with Github Actions so users can just pull the image, as building it is time consuming. It might even be possible to compile for all CPU architectures too (i.e. ARM etc.).
  3. I noticed the program won't exit on CTRL-C at least in the container (tested on 2 machines). Is there a reason that comes to your mind? Using the Docker --init flag allows it to quit gracefully though, but it would be nice not to need it.

Anyway thanks for the great tool 👍

MindFlavor commented 4 years ago

Wow that's amazing, thanks! I will merge it ASAP and create separate issues for point 2 and 3!

PS: iptables in dockers??? :tophat: :clap: :clap: :clap:

qdm12 commented 4 years ago

Great thanks!

Yes even my wireguard is managed from a container I set as aliases in my shell :smile: It is ridiculous, I have no counter argument.

But for your use case, I think it definitely brings value!