1.16 breaks scaling between card sections

MindFreeze / ha-sankey-chart

A Home Assistant lovelace card to display a sankey chart. For example for power consumption

MIT License

379 stars 20 forks source link

1.16 breaks scaling between card sections #142

Closed nathan-curtis closed 11 months ago

nathan-curtis commented 11 months ago

Checklist:

[ X] I updated to the latest version available
[ X] I cleared the cache of my browser

Release with the issue: 1.16.x Last working release (if known): 1.15.x Browser and Operating System: Win11 Moment 4, Edge 118.0.2088.46 (Official build) (64-bit)

ALL Description of problem: Scaling off segments between sections changed between versions - Please revert to 1.15 scaling behavior or provide override option

This picture is 'correct' taken in 1.15.1

This is in 1.16.1 (1.16.0 also shows inconsistent bar scaling as well)

nathan-curtis commented 11 months ago

Not fixed in 1.17:

Specifically look at section 5, second item - IT Closet Trace that back one step - What the heck is going on there? why are the lobes changing size? I expect that bar once it breaks off - to maintain relative width 0.97KwH should be represented as the same amount relative to the unit - not relative to the percent visible on a 100% bar

It looks like you're trying to scale the window to 100% top/bottom for each - NO stack the energy values based on the smallest unit displayed and the chart height is the chart height please see the first.

MindFreeze commented 11 months ago

Ah, I think I see where the problem is. Will fix in next version

nathan-curtis commented 11 months ago

fixed in 1.17.1: