MindTheGap-ERC / CarboKitten.jl

Julia implementation of carbonate platform model
https://mindthegap-erc.github.io/CarboKitten.jl/
GNU General Public License v3.0
0 stars 0 forks source link

Add units #18

Open EmiliaJarochowska opened 6 months ago

EmiliaJarochowska commented 6 months ago

The parameters, outputs and plots should keep track of units. How to do it? Discuss with @jhidding

jhidding commented 6 months ago

Found this: https://github.com/PainterQubits/Unitful.jl

EmiliaJarochowska commented 6 months ago

Looks good, if a bit big-ish. More dependencies to precompile 😅

jhidding commented 6 months ago

my choice for model units would boil down to:

EmiliaJarochowska commented 6 months ago

E is a historically important unit, if obsolete now: https://en.wikipedia.org/wiki/Einstein_(unit)

EmiliaJarochowska commented 6 months ago

Looks good. Obviously Einstein sounds more fancy than Watt but the latter is indeed more handy and we should stick to SI. Myr is on the longer end of scales we're looking at but probably the best choice.

EmiliaJarochowska commented 4 months ago

Rescale the facies to W/m^2