MindTheGap-ERC / CarboKitten.jl

Julia implementation of carbonate platform model
https://mindthegap-erc.github.io/CarboKitten.jl/
GNU General Public License v3.0
0 stars 0 forks source link

Wrong operator in CaProd.jl? #24

Closed EmiliaJarochowska closed 5 days ago

EmiliaJarochowska commented 4 months ago

When using the branch xy_test I cannot precompile CarboKitten, because of the following line:

ERROR: LoadError: ParseError:
# Error @ /Users/emilia/Documents/Documents - UU101746/GitHub/CarboKitten/src/CaProd.jl:110:17
        s.height .+= Δ.denudation .* input.Δt  #number already in kyr
        s.height ._= Δ.redistribution .* input.Δt
#               ╙ ── whitespace is not allowed here

I don't recognize the _ operator, there is no ?_ entry. You probably mean -?

EmiliaJarochowska commented 4 months ago

I was curious if it was the only issue so I re-ran it with - instead of _ but I still got the error Package CarboKitten does not have PhysicalErosion in its dependencies. I added include("./PhysicalErosion.jl") to CarboKitten.jl and ran Pkg.resolve() but that gave me the following:

ERROR: Unsatisfiable requirements detected for package StableHashTraits [c5dd0088]:
 StableHashTraits [c5dd0088] log:
 ├─possible versions are: 0.1.1-1.1.6 or uninstalled
 ├─restricted to versions 1.1.3 by an explicit requirement, leaving only versions: 1.1.3
 └─restricted by julia compatibility requirements to versions: 1.1.5-1.1.6 or uninstalled — no versions left

I think the changes above are needed anyways, but I'm not going to PR because I can't check if it works without fixing the problem with StableHashTraits

xyl96 commented 4 months ago

Yes I know, I have already changed it in my computer and I haven't pushed it yet

On Sat, 2 Mar 2024, 12:27 Emilia Jarochowska, @.***> wrote:

I was curious if it was the only issue so I re-ran it with - instead of _ but I still got the error Package CarboKitten does not have PhysicalErosion in its dependencies. I added include("./PhysicalErosion.jl") to CarboKitten.jl and ran Pkg.resolve() but that gave me the following:

ERROR: Unsatisfiable requirements detected for package StableHashTraits [c5dd0088]: StableHashTraits [c5dd0088] log: ├─possible versions are: 0.1.1-1.1.6 or uninstalled ├─restricted to versions 1.1.3 by an explicit requirement, leaving only versions: 1.1.3 └─restricted by julia compatibility requirements to versions: 1.1.5-1.1.6 or uninstalled — no versions left

I think the changes above are needed anyways, but I'm not going to PR because I can't check if it works without fixing the problem with StableHashTraits

— Reply to this email directly, view it on GitHub https://github.com/MindTheGap-ERC/CarboKitten.jl/issues/24#issuecomment-1974770310, or unsubscribe https://github.com/notifications/unsubscribe-auth/APJQBVPHJSBQX7XAY76LYILYWGZRVAVCNFSM6AAAAABEDAQVT2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNZUG43TAMZRGA . You are receiving this because you were assigned.Message ID: @.***>

xyl96 commented 4 months ago

I currently don't have the physical erosion issue. But I have to admit that the visulisation is a conflict.

EmiliaJarochowska commented 3 months ago

@xyl96 can you confirm that this issue is resolved in your branch?

EmiliaJarochowska commented 2 weeks ago

Hello is anybody here?

xyl96 commented 2 weeks ago

Hello is anybody here?

yes.

EmiliaJarochowska commented 2 weeks ago

Is this issue resolved? I'm getting lost in all the issues and branches here ;-)

xyl96 commented 2 weeks ago

Is this issue resolved? I'm getting lost in all the issues and branches here ;-)

yes, because I haven't met this on my computer this time.